109849e438
Owner's ruling. Measured over the twelve baseline layouts as realised value per m2 (rate x quality, not the rate alone): as shipped before this room 67.0 terrace 294.6 violates, 4.39x value_supported=100 only room 67.0 terrace 98.2 violates, 1.46x geometric mean only room 132.9 terrace 296.8 violates, 2.23x both room 132.9 terrace 98.9 satisfies The 4.4x is roughly 2.2x aggregation and 2.0x rate, so neither half alone is enough. That is why 39.18's geometric-mean aggregation moves from default-OFF to default-ON here rather than waiting on its own A/B: it is not an optional improvement, it is half of a ruling. value_supported 300 -> 100, and set to value_outside rather than to a number that makes the inequality come out -- back-solving from the corpus's measured mean room quality would rot the moment either changed. Outdoor space is worth the same to an occupant whatever level it sits on; the real difference between a ground garden and a roof terrace is what it takes to BUILD, and cost already says that (outside 10.0 vs outside_supported 110.0). Value describes worth, cost describes structure, and the level belongs in the second. Changed in CONF_DEFAULTS and the four corpus patterns.config files, which all declared 300.0 explicitly. NOT changed in harbor-house-l0 (a shape-curve test fixture) or y51-sweep-* (historical fixtures that exist to reproduce past measurements) -- repricing those would destroy what they are for. Neither change can move a fail, structurally rather than luckily: value rates never enter fail emission, and evaluate_leaf emits each fail from its factor before anything is combined. Verified corpus-wide: identical fail sets, scores +11% to +169% (and -5% once, on a layout that is mostly terrace). tests/test_terrace_value_ruling.py pins the ruling as an invariant of the objective, and asserts that reverting the aggregation breaks it again, so neither half can be quietly dropped. The 500k cold-start baseline (39.12) is superseded -- this changes what "good" means. The layouts stay valid and their fail counts are unchanged, but a fresh corpus run is needed before any new number is compared with them. Still untouched: circulation returns 0.07 per unit cost against a room's 0.66, by far the worst thing a building can contain. That is homemaker-py-hxi. Refs homemaker-py-ecx. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01MJ84Feep79Hhm3E4zZJmnB
77 lines
3.1 KiB
Python
77 lines
3.1 KiB
Python
"""A terrace must not be worth more per square metre than a real internal room.
|
|
|
|
Owner's ruling, DESIGN.md §39.19. It is an invariant of the objective rather
|
|
than a property of any one layout, and it needs BOTH halves of §39.18/§39.19 to
|
|
hold — the rate alone leaves a terrace 1.46x a room, the aggregation alone
|
|
2.23x. This asserts it end to end on the corpus, so that flipping either back
|
|
fails loudly here rather than quietly in a six-hour run.
|
|
"""
|
|
|
|
from __future__ import annotations
|
|
|
|
from collections import defaultdict
|
|
from pathlib import Path
|
|
|
|
import pytest
|
|
|
|
from homemaker_layout import dom as dom_mod, geometry
|
|
from homemaker_layout.fitness import Fitness, load_config
|
|
|
|
EXAMPLES = Path(__file__).resolve().parent.parent / "examples"
|
|
CORPUS = ["harbor-house", "maple-court", "health-centre", "programme-house"]
|
|
pytestmark = pytest.mark.skipif(not (EXAMPLES / "harbor-house").is_dir(),
|
|
reason="examples absent")
|
|
|
|
|
|
def _value_per_m2(overrides=None):
|
|
"""(room, terrace) mean value per m2 over the committed baseline layouts."""
|
|
acc = defaultdict(lambda: [0.0, 0.0])
|
|
for name in CORPUS:
|
|
d = EXAMPLES / name
|
|
for p in sorted(d.glob("coldstart-500000-s*.dom")):
|
|
conf, cost = load_config(d, overrides=overrides)
|
|
fit = Fitness(conf, cost)
|
|
orig = Fitness.evaluate_leaf
|
|
|
|
def ev(self, leaf, G, level_id, groups, fail, _o=orig):
|
|
q, f = _o(self, leaf, G, level_id, groups, fail)
|
|
if dom_mod.is_outside(leaf):
|
|
kind = "terrace" if dom_mod.level_of(leaf) else None
|
|
elif dom_mod.is_circulation(leaf):
|
|
kind = None
|
|
else:
|
|
kind = "room"
|
|
if kind:
|
|
a = geometry.area(leaf)
|
|
acc[kind][0] += a
|
|
acc[kind][1] += q * self.value_rate(leaf) * a
|
|
return q, f
|
|
|
|
Fitness.evaluate_leaf = ev
|
|
try:
|
|
fit.score_with_fails(dom_mod.load(str(p)))
|
|
finally:
|
|
Fitness.evaluate_leaf = orig
|
|
return tuple(acc[k][1] / acc[k][0] for k in ("room", "terrace"))
|
|
|
|
|
|
def test_a_terrace_is_worth_less_per_m2_than_a_room():
|
|
room, terrace = _value_per_m2()
|
|
assert terrace < room, (
|
|
f"terrace {terrace:.1f}/m2 >= room {room:.1f}/m2 — §39.19 ruling broken")
|
|
|
|
|
|
def test_the_rate_alone_would_not_be_enough():
|
|
"""Documents why the aggregation default moved with the rate: revert the
|
|
aggregation and the ruling breaks again, so neither half is optional."""
|
|
room, terrace = _value_per_m2({"quality_aggregate": "product"})
|
|
assert terrace > room, (
|
|
"the product aggregation no longer violates the ruling — if that is a "
|
|
"real improvement, §39.19's reasoning needs revisiting")
|
|
|
|
|
|
def test_value_supported_is_the_outdoor_rate_not_the_indoor_one():
|
|
for name in CORPUS:
|
|
conf, _ = load_config(EXAMPLES / name)
|
|
assert conf["value_supported"] == conf["value_outside"], name
|
|
assert conf["value_supported"] < conf["value_inside"], name
|